Merge pull request #1052 from googlefonts/issue1014

Don't error on setting advance width for empty glyph
googlefonts · Jan 12, 2024 · 0f8f930 · 0f8f930
2 parents 9ef58c1 + 956f0e0
commit 0f8f930
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/fontra/client/web-components/ui-form.js b/src/fontra/client/web-components/ui-form.js
@@ -298,6 +298,10 @@ export class Form extends SimpleElement {
     return Object.keys(this._fieldGetters);
   }
 
+  hasKey(key) {
+    return key in this._fieldGetters;
+  }
+
   getValue(key) {
     const getter = this._fieldGetters[key];
     if (getter === undefined) {

diff --git a/src/fontra/views/editor/panel-selection-info.js b/src/fontra/views/editor/panel-selection-info.js
@@ -320,7 +320,9 @@ export default class SelectionInfoPanel extends Panel {
       pointIndices,
       componentIndices
     );
-    this.infoForm.setValue("dimensions", dimensionsString);
+    if (this.infoForm.hasKey("dimensions")) {
+      this.infoForm.setValue("dimensions", dimensionsString);
+    }
   }
 
   _getSelection() {