simplify cell construction: remove unneeded div

googlefonts · Sep 17, 2023 · cd17e46 · cd17e46
1 parent 4b90e09
commit cd17e46
Showing 1 changed file with 9 additions and 16 deletions.
diff --git a/src/fontra/views/editor/panel-designspace-navigation.js b/src/fontra/views/editor/panel-designspace-navigation.js
@@ -912,24 +912,17 @@ function makeIconCellFactory(iconPaths, triggerOnDoubleClick = false) {
 }
 
 function interpolationErrorCell(item, colDesc) {
-  const iconElement = html.createDomElement("inline-svg", {
-    src: "/tabler-icons/bug.svg",
-  });
   return item[colDesc.key]
-    ? html.div(
-        {
-          style: "width: 1.2em; height: 1.2em; color: #F36;",
-          onclick: (event) => {
-            event.stopImmediatePropagation();
-            dialog(
-              "The source has an interpolation incompatibility",
-              item[colDesc.key],
-              [{ title: "Okay" }]
-            );
-          },
+    ? html.createDomElement("inline-svg", {
+        src: "/tabler-icons/bug.svg",
+        style: "width: 1.2em; height: 1.2em; color: #F36;",
+        onclick: (event) => {
+          event.stopImmediatePropagation();
+          dialog("The source has an interpolation incompatibility", item[colDesc.key], [
+            { title: "Okay" },
+          ]);
         },
-        [iconElement]
-      )
+      })
     : "";
 }