Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrete axis and designspace-5 support #1000

Merged
merged 69 commits into from
Nov 29, 2023
Merged

Discrete axis and designspace-5 support #1000

merged 69 commits into from
Nov 29, 2023

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Nov 27, 2023 •
edited
Loading

This fixes #67.

@justvanrossum
First steps in adding a discrete axis type
291a0b6
@justvanrossum
Add comments
49c7800
@justvanrossum
Improve type check and error message
54c9e19
@justvanrossum
Fix field type
ec351e7
@justvanrossum
Fix handling of discrete axis
1f9dd9e
@justvanrossum
Implement discrete axis
a6f6162
@justvanrossum
Skip discrete axis in combinedAxes property
4a75f10
@justvanrossum
Upgrade to DS5, add discrete axis
d9dabd3
@justvanrossum
Fix test expectations
52c7c1b
@justvanrossum
Add descrete axis
72db70b
@justvanrossum
Make combinedAxes skip discrete axes for now
ef331a6
@justvanrossum
Add js equivalent to Python's itertools.product()
dcdc247
@justvanrossum
Test some edge cases
a117109
@justvanrossum
Beginnings of DiscreteVariationModel
bf61bfd
@justvanrossum
Start using discrete axes + DiscreteVariationModel
1745bce
@justvanrossum
Ensure we use valid value choices
21ea343
@justvanrossum
Make source contributions work again
006ac42
@justvanrossum
Fix locationIndices; use index so we don't have to .shift()
78bd240
@justvanrossum
Let getSourceContributions() remap the source order to the expected o…
3e28788 
…rder
@justvanrossum
Factor out computation work from cached prop
cf45004
@justvanrossum
rename func
a68c683
@justvanrossum
Fix interpolation status for discrete axes
262017a
@justvanrossum
Remove obsolete workaround
81bcd48
@justvanrossum
Keep the source index, too
3cd1a6b
@justvanrossum
For now, just throw VariationError if we have no locations for the re…
963660a 
…question discrete location
@justvanrossum
Use instanceof instead of checking error.name
e3075ab
@justvanrossum
No need to repeat the class name
faf423a
@justvanrossum
If a requested discrete model doesn't exist, fall back to the nearest…
38bacff 
… available
@justvanrossum
Use gray color for substituted glyphs
3e050a7
@justvanrossum
Use gray color for substituted glyphs
ae09e55
@justvanrossum
Make func public
76ff56e
@justvanrossum
Implement findNearestSourceFromGlobalLocation() in terms of findNeare…
e69871f 
…stLocationIndex()
@justvanrossum
Fix 'nearest' calculation once more
1598d34
@justvanrossum
Make 'combinedAxes' truly mean 'combined', and add 'continuousAxes' a…
5ea20ef 
…s a counterpart to 'discreteAxes'
@justvanrossum
Move interpolation error info from sel info to ds panel
d222526
@justvanrossum
Improve warning text
d4fd9fc
@justvanrossum
Add alert icons, remove exclam triangle
c7e8bf9
@justvanrossum
Use proper icons instead of emoji
7309303
@justvanrossum
Introduce a lighter 'fontra red' for icon use, where the regular red …
75bced6 
…is too dark
@justvanrossum
Add method to get model errors
557710e
@justvanrossum
Improve model error reporting
04da718
@justvanrossum
Use no-break space between arrow and glyph name
b601690
@justvanrossum
Improve model error
8f97c30
@justvanrossum
Refine error icon choice
a4e4066
@justvanrossum
Improve component error reporting
d8957b2
@justvanrossum
Record the entire glyph hierarchy for error reporting
01b637e
@justvanrossum
fiddle with icon appearance
46ff34c
@justvanrossum
Make discreteLocationKey avalable in interpol info object
d821f08
@justvanrossum
Ensure to only 'select all' within the same discrete location
dc14b98
@justvanrossum
Don't allow multi source editing to other discrete locations
bf89d6e
@justvanrossum
Improve exception message
d36ba8f
@justvanrossum
Improve model error message, and omit discrete key if there is none
5ab9b60
@justvanrossum justvanrossum marked this pull request as ready for review November 28, 2023 10:57
@justvanrossum justvanrossum changed the title Discrete axes and designspace-5 support Discrete axis and designspace-5 support Nov 28, 2023
@justvanrossum justvanrossum merged commit 439d667 into main Nov 29, 2023
3 checks passed
@justvanrossum justvanrossum deleted the ds5 branch November 29, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Designspace 5
2 participants
@justvanrossum @simoncozens