-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrete value range slider should be shorter #1026
Conversation
The item spacing is too wide and not consistent: Please make it match the sketch in #1002 |
This is a tricky css problem, I will come back to this later. |
If you have a suggestion, I'd be happy to hear. |
The element could have its own css that depends on the number of values. |
Can you elaborate? @justvanrossum |
Something like: el = html.div({style: `width: ${some_computed_value_based_on_num_values}em;`); or: el.style = `width: ${some_computed_value_based_on_num_values}em;`; |
I don't think you are accounting for the track length bore the first and after the last tickmark. I think the computation should be something like: this.values.length * 20 + margin * 2 Where |
Space before the checkmark is half of thumb width. I tried that, it doesn't help. |
Assigning it to @justvanrossum for the remaining gap issue. |
Fixes #1002