Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped variable fonts should react to global axis sliders #1040

Merged
merged 8 commits into from
Jan 5, 2024
Merged

Dropped variable fonts should react to global axis sliders #1040

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ade54c
Dropped variable fonts should react to global axis sliders
fatih-erikli Dec 27, 2023
9fcacc3
Font-variation-settings applied in reference fonts panel
fatih-erikli Dec 27, 2023
293b46c
Replaced .map with for loop
fatih-erikli Dec 27, 2023
87301e9
Fixed typo in variable name
fatih-erikli Dec 27, 2023
f614603
Move css variable settings to the places where they should be
fatih-erikli Jan 2, 2024
2b9b5a2
Move canvas font variation setting to reference font panel
fatih-erikli Jan 4, 2024
0323e56
Lookup the font variation by axis.name
fatih-erikli Jan 5, 2024
142a931
Fix a renaming mistake
fatih-erikli Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/fontra/views/editor/panel-reference-font.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,20 @@ export default class ReferenceFontPanel extends Panel {
this.requestReferenceFontsPreview();
}
);

editorController.sceneSettingsController.addKeyListener("location", () => {
const fontVariationSettings = [];
for (const axis of this.editorController.fontController.globalAxes) {
fontVariationSettings.push(
`'${axis.tag}' ${this.editorController.sceneSettings.location[axis.tag]}`
justvanrossum marked this conversation as resolved.
Show resolved Hide resolved
);
}
const buildFontVariablesCssString = fontVariationSettings.join(",");
justvanrossum marked this conversation as resolved.
Show resolved Hide resolved
this.contentElement.style.fontVariationSettings = buildFontVariablesCssString;
this.editorController.canvasController.canvas.style.fontVariationSettings =
buildFontVariablesCssString;
this.editorController.canvasController.requestUpdate();
});
}

async requestReferenceFontsPreview() {
Expand Down