Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-menu implementation in menu-panel #1047

Merged
merged 13 commits into from
Feb 20, 2024
Merged

Sub-menu implementation in menu-panel #1047

merged 13 commits into from
Feb 20, 2024

Conversation

fatih-erikli
Copy link
Collaborator

Fixes #1035.

@fatih-erikli fatih-erikli changed the base branch from main to menu-bar January 2, 2024 14:23
@fatih-erikli
Copy link
Collaborator Author

Functionality must be done however the corners visually not looking well yet. @justvanrossum. I will work on it once we make sure it works correct.

@justvanrossum
Copy link
Collaborator

It works well, and looks quite ok. I would prefer the submenu-icon to look more like in macOS:
image

I don't immediately see a suitable unicode for it, although these come close:
image

But I think the "chevron-right" icon from https://tabler.io/icons is best: at least we wouldn't be depending on a system font's appearance.

image

My comment about a more dynamic items list (populated on-demand) applies here as well.

@justvanrossum
Copy link
Collaborator

justvanrossum commented Jan 24, 2024

Some more feedback regarding appearance and behavior.

image
  • The red selected items should align: the submenu should be a bit higher

  • If I look at macOS, the "parent" items gets a different (gray) highlight when you show a sub-sub-menu:

image
  • When you go back to the parent-parent, I think the sub-sub-menu should hide again:
image

@fatih-erikli fatih-erikli marked this pull request as draft January 24, 2024 11:05
@fatih-erikli
Copy link
Collaborator Author

This is not ready yet, I will rethink the storing open menu instances, currently I read them in the DOM layout. The main PR is ready for review.

@fatih-erikli fatih-erikli marked this pull request as ready for review February 20, 2024 23:14
@fatih-erikli fatih-erikli merged commit 5015a38 into menu-bar Feb 20, 2024
1 check passed
@fatih-erikli fatih-erikli deleted the sub-menu branch February 20, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[menu-panel] add submenu mechanism
2 participants