-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-menu implementation in menu-panel #1047
Conversation
Functionality must be done however the corners visually not looking well yet. @justvanrossum. I will work on it once we make sure it works correct. |
It works well, and looks quite ok. I would prefer the submenu-icon to look more like in macOS: I don't immediately see a suitable unicode for it, although these come close: But I think the "chevron-right" icon from https://tabler.io/icons is best: at least we wouldn't be depending on a system font's appearance. My comment about a more dynamic items list (populated on-demand) applies here as well. |
44f0814
to
5cab529
Compare
4104efc
to
7fa6d9b
Compare
This is not ready yet, I will rethink the storing open menu instances, currently I read them in the DOM layout. The main PR is ready for review. |
Fixes #1035.