Modal dialog improvement

[navv-1]

This pr will fix this issue,

and fix #1176

[justvanrossum]

This must be related to #1175 and https://github.com/googlefonts/fontra/pull/1180/files, and I had an uneasy feeling about the fix.

I have an uneasy feeling about the fix in this PR, too: I don't think max-height: 32em; is what we want: it should be able to get as big as possible, with some space above and below.

Indeed, I just tested: try "Add Component", this should show a big list, and it should be as big as possible (within roughly the 80vh).

[navv-1]

Actually, we can also remove the max-height and let it overflow since we have the scrollbar on the edge

[justvanrossum]

Hmm, we shouldn't have that scrollbar at the edge. The dialog should fit on the page (with some margin above and below), and any scrolling should be handled by its contents.

Your original problem is that we get too many scrollbars when the window isn't tall enough, right?

[justvanrossum]

Can you compare how the situation was before #1146? I feel that PR had larger consequences than intended.

[navv-1]

Look at the add and remove button, if we use vh we will get this result when the window isn't tall enough

[justvanrossum]

So what I'm asking is, did that issue exist before #1146 was merged?

[navv-1]

this is after #1145 merged

[justvanrossum]

Ok, so we need to back up more. Was it ok before #1145? Was it ever ok? I need to know whether this is a regression or something that was always broken.

[navv-1]

I tried after #929 merged and it's not different

[justvanrossum]

And before that one?

[navv-1]

Yes, even before the menu bar was merged. I think it's not regression.

[navv-1]

Indeed, I just tested: try "Add Component", this should show a big list, and it should be as big as possible (within roughly the 80vh).

Instead of looking at a long list, I prefer to use the search bar and get a shorter list.

[justvanrossum]

Instead of looking at a long list, I prefer to use the search bar and get a shorter list.

I disagree. I don't want a hardcoded maximum height for the dialog.

I feel that e98e75c / #1170 was wrong, and we should fix #1168 in a different way.

[navv-1]

I just brought back the max-height. The only problem that I found is in the add and remove button. But this kind of situation maybe would never happen in the real world :D

[justvanrossum]

Thanks!

That might be related to the minHeight of the axis list:

fontra/src/fontra/views/editor/panel-designspace-navigation.js

Line 965 in c6d24ef

axisList.minHeight = "6em";

[justvanrossum]

Changing that to "3em" seems to improve it.

[navv-1]

I changed that to 10vh and I think it's much better.

I also add min-height: 10em to the dialog box to prevent it from shrinking too short. It makes dialog a bit higher when it has a short message. I hope it's still acceptable.

[justvanrossum]

Hm, I'm not happy with the use of vh in the list minHeight. This should be an absolute value, and should not depend on the view height. You can tweak the exact value of 3em, but please use em.

Secondly, I am not happy with the taller dialog for short messages. If this is to make sure the dialog doesn't break for a very small window height: I'm actually ok with some breakage under such tight conditions. The app is not really meant for such small windows.

[navv-1]

Ok, I just follow your suggestion

[justvanrossum]

Thank you once again for your contributions! It's much appreciated.