fix: lock-button-tooltip #1768

[giovanniTramonto]

• handle ui-form overflow and padding on :host (to prevent clipping)
• add form modifier class for selection-info and selection-transformation (keeps flex settings within parent element scope)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ollimeier]

@justvanrossum I checke out the branch and tested it. I can confirm that it fixes the issue with the tooltip:

[justvanrossum]

Does adding padding to :host have any downsides?

[ollimeier]

Does adding padding to :host have any downsides?

I sadly don't have experiences with :host, but I don't read about any downsides. You can simply style :host as any other CSS class.
Please see: https://developer.mozilla.org/en-US/docs/Web/CSS/:host

The following might also be interesting to read:
https://stackoverflow.com/questions/46448385/use-of-host-selector-vs-container-div#answer-46478233

I am wondering if this should be done in other places as well?

[justvanrossum]

My question wasn't about :host, but about adding the padding to the ui-info itself instead of where it is being used.

I'm curious if there is a difference in appearance before and after:

• with long axis names in the selection info panel
• the scroll bar of the selection info panel

[giovanniTramonto]

The branch fixes the clipping issue. But there is more. I’d propose a component panel-section that concerns the overflow and wraps any contents inside. It would allow multiple scrollable boxes in the panel. Then overflow does not need to be a part of ui-form anymore.

[ollimeier]

My question wasn't about :host, but about adding the padding to the ui-info itself instead of where it is being used.

I'm curious if there is a difference in appearance before and after:

• with long axis names in the selection info panel
• the scroll bar of the selection info panel

@justvanrossum I don't see any differences. Here are some screenshots in compare with our main branch:

[justvanrossum]

I don't think we should – at this time – go beyond fixing the issue at hand, though. This looks good, and I will play with it a bit, and then merge.

Btw. please sign that CLA thing....

[giovanniTramonto]

The branch fixes the clipping issue. But there is more. I’d propose a component panel-section that concerns the overflow and wraps any contents inside. It would allow multiple scrollable boxes in the panel. Then overflow does not need to be a part of ui-form anymore.

Proposal #1868