[designspace] Only write classic components if _all_ components in _all_ layers are classic #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was decided on a per layer / per component basis whether it would be stored as a classic component or as a variable component.
This could mess up the component order if a component was considered variable in one source and not in another, even though that can be a perfectly compatible situation.
Additionally, if a component would use tCenterX/Y but no location, it would be stored as a classic component, thereby losing the tCenterX/Y information.
To avoid that, only write classic components if all components in all layers are classic (non-variable).
This fixes #585.