Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool-tip component / fixed botched branch #777

Merged
merged 22 commits into from
Sep 13, 2023
Merged

Conversation

justvanrossum
Copy link
Collaborator

I created a new branch from the proper commits from #763, from before I force-pushed it to pieces.

This should supersede #763 then.

@justvanrossum
Copy link
Collaborator Author

Please make the triangle larger (maybe 50% larger than it is now). I tried to fiddle with the CSS but I can't figure it out.

Please set the font size to 1em. (In most cases we don't use px in Fontra)

@justvanrossum
Copy link
Collaborator Author

Can you make the triangle point more towards the middle of the button?

image

I will fiddle with the colors.

@justvanrossum
Copy link
Collaborator Author

justvanrossum commented Sep 11, 2023

I have tweaked the colors a bit, and the timing.

While the current tooltips look good and work well, I worry about the alignment with different length texts, and how they can be cropped by the window.

I think the tooltips should ideally be centered at their target, but it could be off-center if it otherwise would be cropped by the window. Is something like that hard to do?

@justvanrossum justvanrossum merged commit 8825b9e into main Sep 13, 2023
@justvanrossum justvanrossum deleted the issue-749-fixed branch September 13, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants