Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling + behavior of checkboxes in the source list #778

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

fatih-erikli
Copy link
Collaborator

Work in progress. It will fix #767.

@fatih-erikli
Copy link
Collaborator Author

I implemented that. I creates the whole list from empty div when an item on a list cell has changed, causes flickering when click or doubleclick. ui-list should render only the updated cell for such cases. I leave it as it is for further refactoring.

@justvanrossum
Copy link
Collaborator

I will have a look at the flickering.

Please re-read the issue about which icons to use for the on-off column.

@justvanrossum
Copy link
Collaborator

#792 fixed the flickering. Please rebase.

@fatih-erikli
Copy link
Collaborator Author

I did rebase. Flickering is fixed.

@justvanrossum justvanrossum merged commit 13cd3b0 into main Sep 13, 2023
3 checks passed
@justvanrossum justvanrossum deleted the issue-767 branch September 13, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling + behavior of checkboxes in the source list
2 participants