Work in progress: Implement MIN_CANVAS_SPACE #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure is something I get regularly, and seems to be a glitch. Re-running the failed job usually succeeds. Do you have a clue what could be causing it? |
src/fontra/views/editor/editor.js
Outdated
| @@ -54,7 +55,7 @@ import { | |||
| import { staticGlyphToGLIF } from "../core/glyph-glif.js"; | |||
| import { pathToSVG } from "../core/glyph-svg.js"; | |||
| import { parseClipboard } from "../core/server-utils.js"; | |||
| import Sidebar from "./sidebar.js"; | |||
| import Sidebar, { MAX_SIDEBAR_WIDTH, MIN_SIDEBAR_WIDTH } from "./sidebar.js"; | |||
There was a problem hiding this comment.
Can we turn Sidebar into a "regular" export, instead of a default export? I would love the import line to read like this:
Suggested change
| import Sidebar, { MAX_SIDEBAR_WIDTH, MIN_SIDEBAR_WIDTH } from "./sidebar.js"; | |
| import { Sidebar, MAX_SIDEBAR_WIDTH, MIN_SIDEBAR_WIDTH } from "./sidebar.js"; |
Unit tests? Usually arrayExtend fails. I will try to understand next time it fails. |
fatih-erikli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786.