Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[context-menu] Fix wrong items vertical margins and left padding. #801

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

fabiocaccamo
Copy link
Collaborator

Fix #800

Before

Screenshot 2023-09-13 at 15 43 09

After

Screenshot 2023-09-13 at 15 56 30

@fabiocaccamo fabiocaccamo added the cosmetic bug Something doesn't look quite right label Sep 13, 2023
@fabiocaccamo fabiocaccamo self-assigned this Sep 13, 2023
@fabiocaccamo fabiocaccamo changed the title Fix wrong context-menu items vertical margins and left padding. [context-menu] Fix wrong items vertical margins and left padding. Sep 13, 2023
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! While this is indeed better, I find the top and bottom margins a wee bit too much now. I think 0.25em for both is enough.

@fabiocaccamo
Copy link
Collaborator Author

I tried 0.25em, but I think the last item is too close to the bottom:

Screenshot 2023-09-13 at 17 03 00

@justvanrossum
Copy link
Collaborator

I tried 0.25em, but I think the last item is too close to the bottom:

How about top 0.2, bottom 0.3?

@fabiocaccamo
Copy link
Collaborator Author

I think 0.5 is better because the last item should have the same margins of an item in the middle.

This is 0.2 top, 0.3 bottom:

Screenshot 2023-09-13 at 17 34 53

@justvanrossum
Copy link
Collaborator

I think 0.5 is better because the last item should have the same margins of an item in the middle.

Good point, but that makes me think the space around the dividers is too generous. Can you try to reduce that?

@justvanrossum justvanrossum merged commit ab69c76 into main Sep 14, 2023
3 checks passed
@justvanrossum justvanrossum deleted the context-menu branch September 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic bug Something doesn't look quite right
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[context menu] Wrong vertical margins before first item and after last item.
2 participants