Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-list] Improve scrollbars behaviour. #804

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

fabiocaccamo
Copy link
Collaborator

@fabiocaccamo fabiocaccamo commented Sep 13, 2023

This fixes part of #293.

We can assume that the ui-list is always a vertically scrollable list, but it doesn't need always to be scrolled, so these are the changes:

  • Horizontal scrollbars are always hidden.
  • Vertical scrollbars are visible only if necessary.

@fabiocaccamo fabiocaccamo added the cosmetic bug Something doesn't look quite right label Sep 13, 2023
@fabiocaccamo fabiocaccamo self-assigned this Sep 13, 2023
@fabiocaccamo fabiocaccamo changed the title Improve scrollbars behaviour. [ui-list] Improve scrollbars behaviour. Sep 13, 2023
@fabiocaccamo
Copy link
Collaborator Author

The same changes should be used for #300.

@justvanrossum
Copy link
Collaborator

I will try this later, but I’d like to note that the source list is an example of a list that scrolls horizontally, too.

Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixes the Windows problem ffor ui-list, but not for other scrollable items, such as the ones mentioned in #293 and #300. Let's follow up in additional PRs.

@justvanrossum justvanrossum merged commit f1b4c75 into main Sep 13, 2023
3 checks passed
@justvanrossum justvanrossum deleted the ui-list-scrollbars branch September 13, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic bug Something doesn't look quite right
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants