Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show scrollbars only if needed. #806

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Show scrollbars only if needed. #806

merged 4 commits into from
Sep 14, 2023

Conversation

fabiocaccamo
Copy link
Collaborator

Fix #293
Fix #300

@fabiocaccamo fabiocaccamo added the cosmetic bug Something doesn't look quite right label Sep 14, 2023
@fabiocaccamo fabiocaccamo self-assigned this Sep 14, 2023
justvanrossum
justvanrossum reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of overflow-y: scroll; occurrences that probably should become "auto", too.

src/fontra/views/editor/editor.css Show resolved Hide resolved
@justvanrossum
Copy link
Collaborator

Oh, and one overflow-x: scroll...

@justvanrossum
Copy link
Collaborator

Thanks, I will try this on Windows.

justvanrossum
justvanrossum approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@justvanrossum justvanrossum merged commit 8d27483 into main Sep 14, 2023
3 checks passed
@justvanrossum justvanrossum deleted the scrollbars branch September 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum approved these changes

Assignees

@fabiocaccamo fabiocaccamo

Labels
cosmetic bug Something doesn't look quite right
Projects
Fontra Project
Status: ✅ Done
Milestone
No milestone
2 participants
@fabiocaccamo @justvanrossum