Rotary-like control for angles #981
Conversation
fatih-erikli
force-pushed
the
issue-919
branch
from
944a532 to
35fbb05
Compare
|
Please rebase this. |
fatih-erikli
force-pushed
the
issue-919
branch
from
a24267c to
6df4913
Compare
There was a problem hiding this comment.
- When setting the angle numerically to (say) -50, the thumb get shown rotated counter-clockwise, but when dragging the thumb, the value changes in the opposite direction
- Dragging the thumb is often jumpy
- Dragging to the right rotates clockwise, and draging up rotates counter-clockwise. I think up should also rotate clockwise.
This is fixed. The rotation of glyph on the canvas is applied counterclockwise. There is conversion to the opposite side happening when dragging the thumb. |
|
Maybe I delete the conversion and keep it as it is? The rotation will be applied to the opposite side when dragging the thumb, is that ok? @justvanrossum. |
You mean rotate the rotary control clockwise while the component rotates counter-clockwise? No, they should match, that's the whole point. Btw. please remove that demo panel, and just test with it with a selected component. The movement is still very jumpy: RotationJumpy.mov |
|
Can you test the jumpy behavior with the latest commit? |
|
Hmm no this is a different kind of jumpy behavior. Video has just been loaded. |
|
Hmm, it looks like it's fixed with the latest commit. |
|
It still jumps if you move across the NW - SE axis:
|
|
This is tricky. I tried to fix that by caching the rotation axis, but it expects the drag to be in same direction with when the movement started until the mouse up. |
|
Can you make the rotary control as big as possible without affecting the item spacing? It is currently smaller than the numeric input. Can it be the same size? |
|
Maximum height without affecting the item spacing is the current one. There was a margin, I deleted it, they should seem in same height now. |
Fixes #919.