-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display current character in reference fonts #997
Conversation
Can you rebase this please? |
7405a92
to
72c8d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the slider should be before the text, else it moves up and down after sliding
- Then it can also be a continuous slider (the text responds immediately)
- Please make it a range-slider, so we have the numeric value, too, and proper styling
- The maximum size should be much bigger (maybe 200 or more even)
- The language code should be applied
72c8d8d
to
06b1fd8
Compare
|
It's because multiple events fired to show the preview, resulting multiple times the preview is shown. It was fixed, but I deleted the fix. If an event fired before the previous event is completed, it should be dismissed. I will include the fix again. 07d3365#diff-89f2511fb56caa04c583a1029f729c9022d8a0ec62cebef73c0c99a90e936f2bL308-L318 Something like that should be in the utils I guess, what do you think? |
For the overlapping problem, I don't have a quick solution for that, beside applying a constant max-height. I need to dig into css grid a little bit to find a proper solution. |
The text area should scroll without the size slider. |
576a11b
to
c518468
Compare
Fixes #982.