Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display current character in reference fonts #997

Merged
merged 22 commits into from
Dec 22, 2023
Merged

Display current character in reference fonts #997

merged 22 commits into from
Dec 22, 2023

Conversation

fatih-erikli
Copy link
Collaborator

@fatih-erikli fatih-erikli commented Nov 23, 2023

Fixes #982.

@fatih-erikli fatih-erikli marked this pull request as draft November 23, 2023 13:03
@fatih-erikli fatih-erikli marked this pull request as ready for review December 4, 2023 13:31
@justvanrossum
Copy link
Collaborator

Can you rebase this please?

Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think the slider should be before the text, else it moves up and down after sliding
  • Then it can also be a continuous slider (the text responds immediately)
  • Please make it a range-slider, so we have the numeric value, too, and proper styling
  • The maximum size should be much bigger (maybe 200 or more even)
  • The language code should be applied

@justvanrossum
Copy link
Collaborator

  • the font size should be stored
  • if I change the language code with the popup, it is not applied to the text

@justvanrossum
Copy link
Collaborator

Occasionaly, on reload, the text area duplicates:
image

Can you figure how this can be happening?

Second, if the text doesn't fit anymore, it starts overlapping. I think the text should scroll instead:

image

@fatih-erikli
Copy link
Collaborator Author

It's because multiple events fired to show the preview, resulting multiple times the preview is shown. It was fixed, but I deleted the fix. If an event fired before the previous event is completed, it should be dismissed. I will include the fix again.

07d3365#diff-89f2511fb56caa04c583a1029f729c9022d8a0ec62cebef73c0c99a90e936f2bL308-L318

Something like that should be in the utils I guess, what do you think?

@fatih-erikli
Copy link
Collaborator Author

For the overlapping problem, I don't have a quick solution for that, beside applying a constant max-height. I need to dig into css grid a little bit to find a proper solution.

@justvanrossum
Copy link
Collaborator

The text area should scroll without the size slider.

@justvanrossum justvanrossum merged commit da00393 into main Dec 22, 2023
3 checks passed
@justvanrossum justvanrossum deleted the issue-982 branch December 22, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reference Font] Add area to the panel showing the current character in all reference fonts
2 participants