Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong escape sequences #1007

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aragon999
Copy link

Maybe fixes #1004

Copy link

google-cla bot commented Jul 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -3,4 +3,4 @@

class AutohintOTF(OperationBase):
description = "Run otfautohint"
rule = "otfautohint $args -o $out $in \|\| otfautohint $args -o $out $in --no-zones-stems"
rule = "otfautohint $args -o $out $in \\|\\| otfautohint $args -o $out $in --no-zones-stems"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arrowtype's traceback shows,

otfautohint: error: argument -o/--output: /fonts/Familyname/|| is not a valid path to write to.

The or operator looks well escaped. The issue is that the or operator is attached to the filename. Perhaps quoting the $out and $in args will work e.g

'otfautohint $args -o "$out" "$in" \|\| otfautohint $args -o "$out" "$in" --no-zones-stems'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, probably the $in and $out arguments should be escaped with quotes. I will adjust that. The thing I encountered was actually a Python warning:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Builder] sometimes fails at OTFautohint step because it tries to build || file
2 participants