Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut instances in the Noto recipe provider #1030

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

simoncozens
Copy link
Contributor

Now I've done various bits of optimisation, a good chunk of the time of a Noto build is caught up in instantiating UFOs in order to build static TTFs. I'd like to move towards cutting instances from VFs (that's what the front-end does, so it should be acceptable)...

However, this is currently draft because there are some differences between the cut instances and the UFO-instantiated builds, listed below. So we probably need a gftools-cut-instance which fixes up the problems, and use that instead of purely calling hb-subset.

  • winAscent and winDescent are not updated, neither with fontTools varLib.instancer or hb-subset.
  • hb-subset does not correct the macStyle and fsSelection bits for bold weights, leading to problems with style linking. (fontTools OK here)
  • I got multiple .notdef glyphs with hb-subset. (fontTools OK here)
  • hb-subset does not update the name table (fontTools does).

@simoncozens simoncozens marked this pull request as draft September 20, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant