Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad escapes in string for AutohintOTF #1073

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

RickyDaMa
Copy link
Contributor

Saves a SyntaxWarning in Python 3.12:

image

@m4rc1e
Copy link
Collaborator

m4rc1e commented Dec 19, 2024

Thanks man!

@RickyDaMa
Copy link
Contributor Author

No worries, it's the little things sometimes 😂

@RickyDaMa
Copy link
Contributor Author

I knew this change to ubuntu-latest was going to hurt the font ecosystem: the CI is failing because ubuntu-latest is now ubuntu-24.04 instead of ubuntu-22.04, which doesn't have cairo preinstalled

@m4rc1e
Copy link
Collaborator

m4rc1e commented Dec 19, 2024

like the latest Ubuntu making Cairo go kaboom!

@m4rc1e
Copy link
Collaborator

m4rc1e commented Dec 19, 2024

Eugh, just seen you already spotted this. I'm lazy so just gonna downgrade. Cba to deal with cairo installation on a gha matrix

Saves a SyntaxWarning in Python 3.12
@m4rc1e
Copy link
Collaborator

m4rc1e commented Dec 19, 2024

Rerunning since ci is now fixed.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Dec 19, 2024

Need to buy some M&S gift vouchers so will merge after lunch.

@RickyDaMa
Copy link
Contributor Author

No rush, enjoy!

@m4rc1e m4rc1e merged commit b025165 into googlefonts:main Dec 19, 2024
9 checks passed
@RickyDaMa RickyDaMa deleted the fix-escape branch December 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants