Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gftools-packager --build-from-source #959

Merged
merged 9 commits into from
Jun 6, 2024
Merged

gftools-packager --build-from-source #959

merged 9 commits into from
Jun 6, 2024

Conversation

simoncozens
Copy link
Contributor

This allows us to build a font from source while packaging it.

Notes:

  • Currently it runs gftools-packager on the first config.y*ml or source file it finds in the sources directory. It does not run "make build"
  • Because of this, it runs in the packager's venv. This is deliberate, allowing us to rebuild with a newer toolchain than the frozen one in the repo (bugfixes!). I started the plumbing for a their_venv flag, but haven't implemented it yet.
  • You can provide a "local" config.yaml file in the googlefonts/ofl/familyname directory which is copied into the cloned repository's directory. This potentially allows us to use gftools-builder on things which are not set up to use it in the upstream, or to fiddle with the flags and settings.

@simoncozens simoncozens marked this pull request as ready for review June 3, 2024 13:27
@simoncozens simoncozens requested a review from m4rc1e June 3, 2024 13:27
@simoncozens simoncozens force-pushed the packager-build branch 2 times, most recently from ae9df51 to 5af9ed5 Compare June 5, 2024 11:45
@m4rc1e m4rc1e merged commit 6972a55 into main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants