Update SIDECAR_IMAGE tag in Helm chart variable #4020
Conversation
github-actions
bot
added
kind/cleanup
|
Build Failed 😭 Build Id: 28ed4343-6ce7-417f-b808-5499ac931a10 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Issue #3979 mentioned the specific use case for adding a separate variable to specify the sidecar image is "useful in situations where the sidecar image needs to be pulled from a private registry". Can a image from a private registry be simply specified by a tag, or does it need some sort of repository url with a tag? In other words, how would pulling from a sidecar image a private registry be done with the tag? |
|
We are currently facing an issue with specifying the agones.sdk tag #3978. We are unable to specify the Windows tag and are only using the global tag.To address this, I have declared a specific tag for the SDK images. My question is whether we need to specify the entire URL, or if it would be sufficient to provide an option to declare the other Agones SDK tags? @peterzhongyi |
|
@kangjk1017 Since you opened this issue, I thought it might be helpful to mention you here - do you think adding a variable to accept other Agones SDK tags will help fix the issue? |
| @@ -123,7 +123,7 @@ spec: | |||
| value: {{ .Values.gameservers.additionalPortRanges | toJson | quote }} | |||
| {{- end }} | |||
| - name: SIDECAR_IMAGE # overwrite the GameServer sidecar image that is used | |||
| value: "{{ .Values.agones.image.registry }}/{{ .Values.agones.image.sdk.name}}:{{ default .Values.agones.image.tag .Values.agones.image.sdk.tag }}" | |||
There was a problem hiding this comment.
I think what was asking for is expose a variable to set the registry for SIDECAR_IMAGE separately rather than using agones.image.registry
There was a problem hiding this comment.
user has provided a comment regarding the same queries. (#3979 (comment))
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes: #3979
Closes #3979
Special notes for your reviewer: