Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): accept doc, licen[cs]e, and readme with non-rpm #698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scop
Copy link
Contributor

@scop scop commented Aug 12, 2023

See commentary in code for elaboration.

This PR might be a bit incomplete: untested, no test coverage I think, and perhaps RPM should be dropped from the type names (with aliases for backwards compatibility) to make it clearer that files with them do get included with non-rpm packagers too.

Anyway, submitting here already in this form for discussion, before spending more time on it.

One example case is at https://github.com/aakso/ssh-inscribe/blob/7922b3e15f5fd9569c927f1464982c6f9e870f5b/.goreleaser.yaml#L69-L82. Note how the LICENSE and README.md entries need to be duplicated for deb and rpm; deb without the type info, rpm with it. It would get worse if there were more packager types enabled.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2023
@caarlos0
Copy link
Member

hmm, yes, I think that if we do this, we need to type-alias et al to make it compatible with previous versions, or bump nfpm to v3

@caarlos0 caarlos0 modified the milestones: v2.35.0, 2.36.0 Dec 17, 2023
@caarlos0 caarlos0 modified the milestones: 2.36.0, 2.37.0, 2.38.0 May 8, 2024
@caarlos0 caarlos0 modified the milestones: 2.38.0, 2.39.0 Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants