restrict multiple expectations on same method

goshacodes · Sep 28, 2024 · 52f6994 · 52f6994
1 parent d0787f8
commit 52f6994
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/main/scala/backstub/internal/StubCreation.scala b/src/main/scala/backstub/internal/StubCreation.scala
@@ -163,6 +163,9 @@ class StubCreation(using override val quotes: Quotes) extends StubUtils:
         } =>
           val method = methods.searchMethod(select.asTerm, None, TypeRepr.of[res])
 
+          if (expectations.exists(_._1.symbol == method.symbol))
+            report.errorAndAbort(s"Expectation for ${select.asTerm.show(using Printer.TreeShortCode)} is already set")
+
           val expectation = Expectation(value.asTerm)
           loop(rest, (method -> expectation) :: expectations)
 
@@ -173,6 +176,9 @@ class StubCreation(using override val quotes: Quotes) extends StubUtils:
         } =>
           val method = methods.searchMethod(select.asTerm, Some(TypeRepr.of[Tuple1[arg]]), TypeRepr.of[res])
 
+          if (expectations.exists(_._1.symbol == method.symbol))
+            report.errorAndAbort(s"Expectation for ${select.asTerm.show(using Printer.TreeShortCode)} is already set")
+
           val expectation = Expectation(apply.asTerm)
           loop(rest, (method -> expectation) :: expectations)
 
@@ -184,6 +190,10 @@ class StubCreation(using override val quotes: Quotes) extends StubUtils:
             .returns((${apply}: args => res))
         } =>
           val method = methods.searchMethod(select.asTerm, Some(TypeRepr.of[args]), TypeRepr.of[res])
+
+          if (expectations.exists(_._1.symbol == method.symbol))
+            report.errorAndAbort(s"Expectation for ${select.asTerm.show(using Printer.TreeShortCode)} is already set")
+
           val expectation = Expectation(apply.asTerm)
           loop(rest, (method -> expectation) :: expectations)
 

diff --git a/src/test/scala/backstub/ExpectationsSpec.scala b/src/test/scala/backstub/ExpectationsSpec.scala
@@ -2,7 +2,7 @@ package backstub
 
 import backstub.*
 
-class ExpectationsSpec extends munit.FunSuite with Stubs {
+class ExpectationsSpec extends munit.FunSuite with Stubs:
 
   override def afterEach(context: AfterEach) =
     resetStubs()
@@ -20,7 +20,7 @@ class ExpectationsSpec extends munit.FunSuite with Stubs {
   test("zero args"):
     val foo = stub[Foo]:
       Expect[Foo]
-        .method[String](_.zeroArgs).returnsOnly("5")
+        .method(_.zeroArgs).returnsOnly("5")
 
     val res = foo.zeroArgs
     foo.zeroArgs
@@ -83,4 +83,3 @@ class ExpectationsSpec extends munit.FunSuite with Stubs {
     assert(secondCalls == List((1, true)))
     assert(thirdCallsTimes == 1)
 
-}