Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to support java11+, modify it to a modular project #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

leewyatt
Copy link

@leewyatt leewyatt commented Feb 9, 2023

Hello
Thank you for writing this project very useful;
In order to support java11 and above versions, I tried to modify the project;
Note: Because java9+ supports modularization, in order to reduce dependent modules, I made the following attempts;

  1. Convert FXML file to java code; you can delete the dependency of javafx.fxml module
  2. Deleted jna, jna-platform dependencies; fx13+ solves the bug that transparent/undecorated stage cannot be minimized by clicking the icon.

My English is not good. I used translation software to translate the above content. I hope the translation software can express my meaning clearly;

Thank you

@leewyatt
Copy link
Author

Considering that there are still many users in Java8. It may be necessary to open a new branch to support users using java11+, which may be a good choice.

@goxr3plus
Copy link
Owner

This is a huge update , it takes time for me to check all :) . By the way i am using Fx-BorderlessScene with my JavaFX project https://github.com/goxr3plus/XR3Player which is using Java 20 and it works perfectly ...

@leewyatt
Copy link
Author

Hi, Some developers do not prefer to use FXML for creating UI and would rather not import or rely on the FXML module. This is personally why I think an update might be useful. Of course, the decision to update lies with you.
BTW: The music player you've written is really cool and I've loved it ever since I downloaded and used it. Thank you!
---The above content was translated using a web translator. I hope it can accurately express my thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants