Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2128 Add segmentName to publisher/client/server options #3

Open
wants to merge 1 commit into
base: iox-#2128-named-mepoo-segment
Choose a base branch
from

Conversation

gpalmer-latai
Copy link
Owner

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

PR #3 in the chain implementing eclipse-iceoryx#2128 whose design is described here

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

  • Closes TBD

@gpalmer-latai gpalmer-latai force-pushed the iox-#2128-publish-options-segment-name branch from f09de4c to 0fb780b Compare January 11, 2024 14:56
Copy link

@anolley-latai anolley-latai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -947,7 +947,7 @@ TEST_F(PoshRuntime_test, ShutdownUnblocksBlockingPublisher)
iox::capro::ServiceDescription serviceDescription{"don't", "stop", "me"};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the ones where I just added an empty string to the publisher options I think I'll leave out the copyright. It's not a significant change.

@gpalmer-latai gpalmer-latai force-pushed the iox-#2128-named-mepoo-segment branch 2 times, most recently from 8b87dd7 to 84481de Compare January 12, 2024 15:03
@gpalmer-latai gpalmer-latai force-pushed the iox-#2128-publish-options-segment-name branch from 0fb780b to 47a49c3 Compare January 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants