Test fixes for alignment validation landing #4016
Conversation
|
You mentioned this being part of a spec discussion for the align(1) |
| pass: false, | ||
| // EXCEPTION: Error: Unexpected validation error occurred: | ||
| // Error while parsing WGSL: :6:10 error: alignment must be a | ||
| // multiple of '4' bytes for the 'uniform' address space @align(1) a: i32, |
There was a problem hiding this comment.
whoops, no this is wrong.
The real check is whether the offset if incorrect.
There was a problem hiding this comment.
Based on our discussion it sounds like this change is correct.
Shall i remove the extraneous comment in the source
There was a problem hiding this comment.
ok, after a bunch of discussion, we agreed to change Tint to be more in line with Naga and WebKit.
crbug.com/379760170 is the Tint change.
But also clarify the spec: gpuweb/gpuweb#4978
There was a problem hiding this comment.
LGTM.
Given the proposed spec change, additional tests will be needed. For followup.
|
Some of these tests only consider the case of storage and uniform and not workgroup |
| pass: false, | ||
| // EXCEPTION: Error: Unexpected validation error occurred: | ||
| // Error while parsing WGSL: :6:10 error: alignment must be a | ||
| // multiple of '4' bytes for the 'uniform' address space @align(1) a: i32, |
There was a problem hiding this comment.
LGTM.
Given the proposed spec change, additional tests will be needed. For followup.
Issue:
crbug.com/375467276
Change (correct validation) that introduced this issue
https://dawn-review.googlesource.com/c/dawn/+/212315