Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set MaxRAM and MaxRAMPercentage in launcher for native-image driver" #412

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Mar 27, 2024

This reverts commit 7fc9374.

Closes #403

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 27, 2024
@zakkak zakkak requested a review from jerboaa March 27, 2024 10:30
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, although I still don't like the upstream solution. Sigh.

@zakkak
Copy link
Collaborator Author

zakkak commented Mar 27, 2024

I understand, but it's still better than nothing and we should better not diverge. So it is what it is.

@zakkak zakkak merged commit 185bf04 into graalvm:master Mar 27, 2024
5 checks passed
@zakkak zakkak deleted the 2024-03-27-revert-366 branch March 27, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
2 participants