Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable context propagation by default for 2.0 #1567

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

grcevski
Copy link
Contributor

Since we are preparing for release 2.0 we should disable the new network based context propagation, until we've tested the support more extensively and let people try it on their own terms for a bit.

After some careful consideration I think we need to do couple of more checks before we can enable this by default at all times:

  1. We should only enable this if the customer is exporting traces, for metrics this option only adds overhead and doesn't have any useful impact.
  2. We need to ensure the TC is working correctly before we can enable this. The main challenge is our header injection at L7, which relies on two components. The sock_msg filter is extending the packet, while TC writes the data. If for various reasons, mainly because of improper chaining of TC we fail to run our TC program, the extension of the header value will break the HTTP protocol.
  3. We should test how this behaves with sidecars, which is not a test we currently have. Namely, what happens if each individual sidecar registers a TC for it's interface and the sock message is done at the default host cgroup.

@grcevski grcevski requested a review from a team as a code owner January 23, 2025 14:37
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (285162b) to head (a4d71b4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
+ Coverage   71.15%   71.17%   +0.02%     
==========================================
  Files         197      197              
  Lines       19671    19671              
==========================================
+ Hits        13996    14001       +5     
+ Misses       4995     4993       -2     
+ Partials      680      677       -3     
Flag Coverage Δ
integration-test 53.12% <ø> (-0.20%) ⬇️
k8s-integration-test 52.74% <ø> (-0.62%) ⬇️
oats-test 32.57% <ø> (-1.68%) ⬇️
unittests 47.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fair enough, indeed!

@marevers marevers self-requested a review January 23, 2025 14:55
Copy link
Collaborator

@marevers marevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit c0ed5d3 into grafana:main Jan 23, 2025
15 checks passed
@grcevski grcevski deleted the disable_context_prop branch January 23, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants