-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numeric dataplane frame types #1067
base: dev-3.0.0
Are you sure you want to change the base?
Conversation
|
||
// CanBeNumericLong asserts if the data frame comply with numeric long type | ||
// https://grafana.com/developers/dataplane/numeric#numeric-long-format-numericlong-sql-table-like | ||
func CanBeNumericLong(frame *data.Frame) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to check for absence of labels as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infinity doesn't make use of labels. So we are good to go here.
If we are doing this is outside of infinity, definitely consider this.
This PR helps to add proper data frame types when the data frame is comply with numeric-wide/numeric-long data frame types.
This will help to handle the scenarios where these result types will be handled properly in alerts, recorded queries, server side expressions etc.
How to test
Before changes
After changes