Httptrace #1087
Open
Httptrace #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger := backend.Logger.FromContext(ctx) | ||
| trace := &httptrace.ClientTrace{ | ||
| GetConn: func(hostPort string) { | ||
| logger.Debug("HTTPTrace event", "event_name", "GetConn") |
There was a problem hiding this comment.
I am wondering if all of these should be level trace because for data source services, we have debug level logging turned on. This would produce a lot of logs that are only sometimes needed. So we could turn it on in that case.
We have trace log level: https://github.com/grafana/grafana-plugin-sdk-go/blob/main/backend/log/log.go#L14, but we are missing logger.Trace() method - all other levels have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nice to have PR and allow us investigate any connection issues. More details about HTTP trace can be found in https://pkg.go.dev/net/http/httptrace
To debug connection issues such as DNS lookup, adding the HTTPTrace event debug logging.
How to test
git checkout httptraceyarn && yarn build && mage -v && docker compose -f ./docker-compose-debug.yaml up