Chore: Fix DeepCopyInto for DataQuery (#1081)

grafana · Sep 11, 2024 · 71cd88b · 71cd88b
1 parent 84021fd
commit 71cd88b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/experimental/apis/data/v0alpha1/query.go b/experimental/apis/data/v0alpha1/query.go
@@ -246,7 +246,7 @@ func (g *DataQuery) DeepCopyInto(out *DataQuery) {
 		out.additional = map[string]any{}
 		if len(g.additional) > 0 {
 			jj, err := json.Marshal(g.additional)
-			if err != nil {
+			if err == nil {
 				_ = json.Unmarshal(jj, &out.additional)
 			}
 		}

diff --git a/experimental/apis/data/v0alpha1/query_test.go b/experimental/apis/data/v0alpha1/query_test.go
@@ -20,7 +20,8 @@ func TestParseQueriesIntoQueryDataRequest(t *testing.T) {
 				"spreadsheet": "spreadsheetID",
 				"datasourceId": 4,
 				"intervalMs": 30000,
-				"maxDataPoints": 794
+				"maxDataPoints": 794,
+				"expr": "{filename=\"/var/log/docker/2e21a640173f1f3359e2a178905dad6b1b56e2da6e3d53dbdba0a1123cdcb4fe/json.log\"} | logfmt"
 			},
 			{
 				"refId": "Z",
@@ -75,6 +76,11 @@ func TestParseQueriesIntoQueryDataRequest(t *testing.T) {
 		  }`, string(out))
 	})
 
+	t.Run("verify deep copy", func(t *testing.T) {
+		cpy := req.DeepCopy()
+		require.Equal(t, req, cpy)
+	})
+
 	t.Run("same results from either parser", func(t *testing.T) {
 		typed := &QueryDataRequest{}
 		err = json.Unmarshal(request, typed)