lint fix

grafana · Oct 11, 2024 · d783f35 · d783f35
1 parent 02ca2a1
commit d783f35
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/backend/httpclient/error_source_middleware_test.go b/backend/httpclient/error_source_middleware_test.go
@@ -26,7 +26,9 @@ func TestErrorSourceMiddleware(t *testing.T) {
 		require.NoError(t, err)
 		resp, err := rt.RoundTrip(req)
 		require.Error(t, err)
-		require.Nil(t, resp)
+		if resp.Body != nil {
+			require.NoError(t, resp.Body.Close())
+		}
 		require.False(t, status.IsDownstreamError(err))
 		require.ErrorIs(t, err, someErr)
 	})
@@ -46,7 +48,9 @@ func TestErrorSourceMiddleware(t *testing.T) {
 		require.NoError(t, err)
 		resp, err := rt.RoundTrip(req)
 		require.Error(t, err)
-		require.Nil(t, resp)
+		if resp.Body != nil {
+			require.NoError(t, resp.Body.Close())
+		}
 		require.True(t, status.IsDownstreamError(err))
 		require.ErrorIs(t, err, someErr)
 	})

diff --git a/backend/httpclient/http_client_test.go b/backend/httpclient/http_client_test.go
@@ -172,7 +172,7 @@ func (c *testContext) createRoundTripper(name string) http.RoundTripper {
 
 func (c *testContext) createRoundTripperWithError(err error) http.RoundTripper {
 	return RoundTripperFunc(func(_ *http.Request) (*http.Response, error) {
-		return nil, err
+		return &http.Response{}, err
 	})
 }