Add X-Grafana-Id header as const #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
requested review from
wbrowne,
andresmgot and
xnyo
and removed request for
a team
|
|
|
|
andresmgot
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Thanks for the PR @jkroepke! It should be fine to add this but it seems that the linter does not agree: https://drone.grafana.net/grafana/grafana-plugin-sdk-go/2404/1/3 Can you disable it for the new line?
jkroepke
commented
Aug 12, 2024
xnyo
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Define the HTTP header used by the idForwarded feature toggle as constant
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: