PDC: add operation canceled error handler to socks proxy dialer #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafydd-t
requested review from
wbrowne,
andresmgot and
oshirohugo
and removed request for
a team
wbrowne
approved these changes
Aug 21, 2024
xnyo
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We're getting socks_unknown_errors for errors ending in
operation was canceled, even though we know these are closed due to sockets being closed or context canceled. Handle this as a context_canceled error.Which issue(s) this PR fixes:
Fixes https://github.com/grafana/hosted-grafana/issues/5759
Special notes for your reviewer: