fix: return response with errorsource instead of nil #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvrzm
requested review from
wbrowne,
andresmgot and
oshirohugo
and removed request for
a team
marefr
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Somewhat related to the changes in #1066 and those changes executes after your changes. I think this should be fine, but it will start sending any errors in clear text to the end users which might include sensitive information. Might need some additional thoughts/discussions
marefr
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
LGTM talked with the team and they reminded me that returning sensitive information for errors might already be happening with CheckHealth. But you should take any sensitive information into account in general that comes from errors - This information might be used by a bad actor to gain information about the hosting environment etc
andresmgot
requested changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently errors from
NewInstanceare returned fromManager.QueryDatawith a nilQueryDataResponse, which obscures the errorsource. This changes that method to return aQueryDataResponsewith the error with errorsource set, which improves both user experience and alerting.Which issue(s) this PR fixes:
Fixes #1068
Fixes #
Special notes for your reviewer: