Add helper for batching DataQueries by time range #1178
Closed
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
force-pushed
the
add-time-batch-helper
branch
from
413d938 to
75f920d
Compare
3 tasks
iwysiu
requested review from
wbrowne,
andresmgot and
xnyo
and removed request for
a team
andresmgot
reviewed
Dec 19, 2024
| require.Equal(t, 2, len(result)) | ||
| var FiveMinQueries = result[0] | ||
| var TenMinQueries = result[1] | ||
| if len(result[0]) == 1 { |
There was a problem hiding this comment.
can you explain this if? There is nothing variable in this function so not sure why it's needed
| @@ -110,6 +110,21 @@ type DataQuery struct { | |||
| JSON json.RawMessage | |||
| } | |||
|
|
|||
| func BatchDataQueriesByTimeRange(queries []DataQuery) [][]DataQuery { | |||
There was a problem hiding this comment.
Can you add documentation about this function?
Also, I don't think backend is the right package for this utility, I would first add it in experimental or maybe gtime.
|
Talked with @gabor , decided to add this directly to cloudwatch for now and we can move it to the plugin-sdk if we find that it's a good solution for other datasources with this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a helper function to separate a batch of queries into smaller batches by time range. This function can be used in datasource plugins that need to batch their queries before sending them to the datasources.
Which issue(s) this PR fixes:
Part of grafana/grafana#85495
Special notes for your reviewer:
We could also get the string values of the time range fields to use as the key, but that didn't seem necessary to me.