Add datasource label to secure_socks_requests_duration #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoorlyDefinedBehaviour
requested review from
wbrowne,
marefr and
xnyo
and removed request for
a team
PoorlyDefinedBehaviour
force-pushed
the
add-datasource-label-to-secure_socks_requests_duration
branch
4 times, most recently
from
7f92af6 to
5ebee79
Compare
PoorlyDefinedBehaviour
force-pushed
the
add-datasource-label-to-secure_socks_requests_duration
branch
from
5ebee79 to
c4d9b67
Compare
5 tasks
xnyo
reviewed
Jan 22, 2024
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
PoorlyDefinedBehaviour
requested review from
xnyo and
marefr
and removed request for
wbrowne,
marefr and
xnyo
PoorlyDefinedBehaviour
deleted the
add-datasource-label-to-secure_socks_requests_duration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the
datasourceanddatasourceTypelabels tosecure_socks_requests_duration.The operator experience squad wants to expose some Grafana private datasource connect to customers and these labels will make it easier to do so.
Which issue(s) this PR fixes:
Part of https://github.com/grafana/hosted-grafana/issues/5151
Special notes for your reviewer: