Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querying and authentication for Zabbix v7.0+ #1931

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

ivanahuckova
Copy link
Member

@ivanahuckova ivanahuckova commented Dec 12, 2024

Fixes #1914
Fixes #1929
Fixes #1917

  1. In this PR, we are fixing authentication that is currently broken for Zabbix v7.2+ (in some cases also 7.0). The reason is that in 7.0 auth param was deprecated in favour of Auth header and in 7.2 the support was removed: https://www.zabbix.com/documentation/7.0/en/manual/api#authorization-methods

  2. Moreover, the real_hosts was deprecated https://www.zabbix.com/documentation/7.0/en/manual/api/reference/hostgroup/get?hl=real_hosts in favor of with_hosts and support was removed in in 7.2.

  3. And last select_acknowledges was deprecated and replaced with selectAcknowledges. https://www.zabbix.com/documentation/7.0/en/manual/api/reference/event/get?hl=select_acknowledges%2CselectAcknowledges

This PR fixes it and also adds a new docker block for Zabbix 72 for testing.

I have tested this PR with Zabbix 7.2:

zabbix72.mov

I have tested this PR with Zabbix 7.0:

zabbix70.mov

I have also tested with 6.2 and all works as expected.

@ivanahuckova ivanahuckova requested a review from a team as a code owner December 12, 2024 14:25
@ivanahuckova ivanahuckova marked this pull request as draft December 12, 2024 14:36
@ivanahuckova ivanahuckova marked this pull request as ready for review December 12, 2024 15:04
@ivanahuckova ivanahuckova changed the title Fix querying and authentication for Zabbix v7.2.0+ Fix querying and authentication for Zabbix v7.0+ Dec 12, 2024
@yesoreyeram yesoreyeram merged commit dbcc008 into main Dec 17, 2024
4 checks passed
@yesoreyeram yesoreyeram deleted the ivana/auth-72 branch December 17, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
2 participants