LibraryPanels: Expose library panels in dashboard apiserver #92213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
added
no-backport
ryantxu
changed the title
ryantxu
commented
Aug 27, 2024
| @@ -17,6 +17,9 @@ func GetOpenAPIDefinitions(builders []APIGroupBuilder) common.GetOpenAPIDefiniti | |||
| return func(ref common.ReferenceCallback) map[string]common.OpenAPIDefinition { | |||
| defs := v0alpha1.GetOpenAPIDefinitions(ref) // common grafana apis | |||
| maps.Copy(defs, data.GetOpenAPIDefinitions(ref)) | |||
| maps.Copy(defs, map[string]common.OpenAPIDefinition{ // TODO -- move to SDK definition above | |||
There was a problem hiding this comment.
This can be removed when grafana/grafana-plugin-sdk-go#1062 is merged
JohnnyQQQQ
approved these changes
Aug 27, 2024
pkg/apis/dashboard/v0alpha1/types.go
Outdated
Comment on lines
78
to
79
| // The dashboard body (unstructured for now) | ||
| Spec LibraryPanelSpec `json:"spec"` |
There was a problem hiding this comment.
Question: Not sure what you mean by unstructured here, as it seems to have a structure with specific fields?
There was a problem hiding this comment.
I'll update the comment! it was unstructured at first... then I got more ambitious
Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dashboard apiserver so it also returns library panels.
http://localhost:3000/apis/dashboard.grafana.app/v0alpha1/namespaces/default/librarypanels
This includes a slightly improved schema for library panels in k8s -- we can consider using this as a foundation for dashboard panels.
Note: this still requires dev mode and: