Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function tests to cover more cases #669

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

academo
Copy link
Member

@academo academo commented Oct 11, 2024

What this PR does / why we need it:

Updates the compare function tests to cover more cases including arrow functions and function expressions

Which issue(s) this PR fixes:

Closes #221

@academo academo requested a review from a team as a code owner October 11, 2024 08:44
@academo academo requested review from jackw and leventebalogh and removed request for a team October 11, 2024 08:44
@academo academo self-assigned this Oct 11, 2024
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@academo academo merged commit 37513c1 into main Nov 8, 2024
2 checks passed
@academo academo deleted the academo/update-function-tests branch November 8, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

Detect type changes in function parameters for FunctionExpression and ArrowFunction
2 participants