Merge pull request #65 from grafana/domas-make-request-limit-middlewa…

…re-optional feat: make request limit middleware optional
grafana · Jul 26, 2023 · 6b2a4f9 · 6b2a4f9
2 parents 06f9563 + 0fa76b5
commit 6b2a4f9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/appcommon/harness.go b/pkg/appcommon/harness.go
@@ -133,15 +133,17 @@ func New(cfg Config, reg prometheus.Registerer, metricPrefix string, tracer open
 		authMiddleware = middleware.HTTPFakeAuth{}
 	}
 
-	requestLimitsMiddleware := middleware.NewRequestLimitsMiddleware(cfg.ServerConfig.HTTPMaxRequestSizeLimit)
-
 	// Middlewares will be wrapped in order
 	middlewares := []middleware.Interface{
 		tracerMiddleware,
 		instrumentMiddleware,
 		authMiddleware,
 		logMiddleware,
-		requestLimitsMiddleware,
+	}
+
+	if (cfg.ServerConfig.HTTPMaxRequestSizeLimit > 0) {
+		requestLimitsMiddleware := middleware.NewRequestLimitsMiddleware(cfg.ServerConfig.HTTPMaxRequestSizeLimit)
+		middlewares = append(middlewares, requestLimitsMiddleware)
 	}
 
 	srv, err := server.NewServer(logger, cfg.ServerConfig, router, middlewares)