Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Update docker registry to point to docker hub. #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update docker registry to point to docker hub. #488

wants to merge 1 commit into from

Conversation

simonswine
Copy link
Collaborator

Most likely a remnant from "before launch" times.

@simonswine
Update docker registry to point to docker hub.
ce164f4 
Most likely a remnant from "before launch" times.
@simonswine simonswine marked this pull request as ready for review January 25, 2023 11:11
cyriltovena
cyriltovena approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that push to dockerhub too in the CI ?

@cyriltovena
Copy link
Collaborator

Wondering if this fixes grafana/pyroscope#2109 ?

@simonswine
Copy link
Collaborator Author

Wondering if this fixes grafana/pyroscope#2109 ?

Good point, it can and maybe it should? What do you think?

Will that push to dockerhub too in the CI ?

I think we might need some lightly different secrets for it, but in theory yes.

@cyriltovena
Copy link
Collaborator

I want to push to dockerhub only I think so let's see

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonswine @cyriltovena