Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Use module.tsx in is-compatible workflow for apps #1384

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

leventebalogh
Copy link
Collaborator

@leventebalogh leventebalogh commented Dec 6, 2024

What changed?

The is-compatible workflow template always used the .ts extension for module.ts, although app plugins are now scaffolded with module.tsx, which causing issues in new app plugin scaffolds (for example in the cmab-app) This PR updates the is-compatible workflow template to use module.tsx in case we are scaffolding an app plugin.

Thanks @gubjanos for flagging this 🙏

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install website@3.5.2-canary.1384.e2b8c3c.0
npm install @grafana/create-plugin@5.12.4-canary.1384.e2b8c3c.0
npm install @grafana/plugin-e2e@1.14.2-canary.1384.e2b8c3c.0
npm install @grafana/plugin-meta-extractor@0.0.10-canary.1384.e2b8c3c.0
npm install @grafana/plugin-types-bundler@0.2.1-canary.1384.e2b8c3c.0
npm install @grafana/sign-plugin@3.0.6-canary.1384.e2b8c3c.0
# or 
yarn add website@3.5.2-canary.1384.e2b8c3c.0
yarn add @grafana/create-plugin@5.12.4-canary.1384.e2b8c3c.0
yarn add @grafana/plugin-e2e@1.14.2-canary.1384.e2b8c3c.0
yarn add @grafana/plugin-meta-extractor@0.0.10-canary.1384.e2b8c3c.0
yarn add @grafana/plugin-types-bundler@0.2.1-canary.1384.e2b8c3c.0
yarn add @grafana/sign-plugin@3.0.6-canary.1384.e2b8c3c.0

@leventebalogh leventebalogh added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged type/bug Something isn't working no-changelog Don't include in changelog and version calculations labels Dec 6, 2024
@leventebalogh leventebalogh self-assigned this Dec 6, 2024
@leventebalogh leventebalogh requested a review from a team as a code owner December 6, 2024 11:10
Copy link

github-actions bot commented Dec 6, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@leventebalogh leventebalogh removed the no-changelog Don't include in changelog and version calculations label Dec 6, 2024
@leventebalogh leventebalogh force-pushed the leventebalogh/is-compatible-workflow-template branch from cc973b3 to e2b8c3c Compare December 31, 2024 12:05
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@leventebalogh leventebalogh merged commit e6043f6 into main Dec 31, 2024
13 checks passed
@leventebalogh leventebalogh deleted the leventebalogh/is-compatible-workflow-template branch December 31, 2024 13:03
@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released. type/bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants