-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Plugin: Use module.tsx
in is-compatible workflow for apps
#1384
Merged
leventebalogh
merged 2 commits into
main
from
leventebalogh/is-compatible-workflow-template
Dec 31, 2024
Merged
Create Plugin: Use module.tsx
in is-compatible workflow for apps
#1384
leventebalogh
merged 2 commits into
main
from
leventebalogh/is-compatible-workflow-template
Dec 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leventebalogh
added
create-plugin
related to the create-plugin tool
patch
Increment the patch version when merged
release
Create a release when this pr is merged
type/bug
Something isn't working
no-changelog
Don't include in changelog and version calculations
labels
Dec 6, 2024
leventebalogh
removed
the
no-changelog
Don't include in changelog and version calculations
label
Dec 6, 2024
academo
reviewed
Dec 6, 2024
packages/create-plugin/templates/github/workflows/is-compatible.yml
Outdated
Show resolved
Hide resolved
academo
approved these changes
Dec 6, 2024
leventebalogh
force-pushed
the
leventebalogh/is-compatible-workflow-template
branch
from
December 31, 2024 12:05
cc973b3
to
e2b8c3c
Compare
jackw
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
leventebalogh
deleted the
leventebalogh/is-compatible-workflow-template
branch
December 31, 2024 13:03
grafana-plugins-platform-bot
bot
added
the
released
This issue/pull request has been released.
label
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
create-plugin
related to the create-plugin tool
patch
Increment the patch version when merged
release
Create a release when this pr is merged
released
This issue/pull request has been released.
type/bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The is-compatible workflow template always used the
.ts
extension formodule.ts
, although app plugins are now scaffolded withmodule.tsx
, which causing issues in new app plugin scaffolds (for example in the cmab-app) This PR updates the is-compatible workflow template to usemodule.tsx
in case we are scaffolding an app plugin.Thanks @gubjanos for flagging this 🙏
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install website@3.5.2-canary.1384.e2b8c3c.0 npm install @grafana/create-plugin@5.12.4-canary.1384.e2b8c3c.0 npm install @grafana/plugin-e2e@1.14.2-canary.1384.e2b8c3c.0 npm install @grafana/plugin-meta-extractor@0.0.10-canary.1384.e2b8c3c.0 npm install @grafana/plugin-types-bundler@0.2.1-canary.1384.e2b8c3c.0 npm install @grafana/sign-plugin@3.0.6-canary.1384.e2b8c3c.0 # or yarn add website@3.5.2-canary.1384.e2b8c3c.0 yarn add @grafana/create-plugin@5.12.4-canary.1384.e2b8c3c.0 yarn add @grafana/plugin-e2e@1.14.2-canary.1384.e2b8c3c.0 yarn add @grafana/plugin-meta-extractor@0.0.10-canary.1384.e2b8c3c.0 yarn add @grafana/plugin-types-bundler@0.2.1-canary.1384.e2b8c3c.0 yarn add @grafana/sign-plugin@3.0.6-canary.1384.e2b8c3c.0