Template Variables: Use Combobox behind toggle #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
packages/scenes/src/variables/components/VariableValueSelect.tsx
Outdated
Show resolved
Hide resolved
tskarhed
commented
Jan 22, 2025
|
|
||
| return ( | ||
| <Combobox | ||
| id={'var-' + key} |
There was a problem hiding this comment.
Not sure where this var- is added for the Select
| let comboboxOptions = options.map((o) => ({ value: o.value.toString(), label: o.label })); | ||
|
|
||
| if (includeAll) { | ||
| comboboxOptions.unshift({ value: ALL_VARIABLE_VALUE, label: ALL_VARIABLE_TEXT }); |
There was a problem hiding this comment.
Are custom All values handled somewhere else?
tskarhed
commented
Jan 24, 2025
| function VariableValueCombobox({ model }: SceneComponentProps<MultiValueVariable>) { | ||
| const { value, key, options, includeAll, isReadOnly, allowCustomValue = true } = model.useState(); | ||
|
|
||
| let comboboxOptions = options.map((o) => ({ value: o.value.toString(), label: o.label })); |
There was a problem hiding this comment.
Do options always have a label in this context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Combobox actually isn't exported until 11.5. I would really appreciate some feedback on the way of handling feature toggling here. This PR will likely be WIP until mid-January.
Try running with grafana/ui at
11.5.0-214403.