Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve demo app navigation and include code highlighter #1023

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

improve demo app navigation and include code highlighter #1023

wants to merge 11 commits into from

Conversation

yduartep
Copy link

@yduartep yduartep commented Jan 8, 2025 •
edited
Loading

This PR includes:

  • Improvement on the navigation when switching between the 3 different demo apps. Currently It's necessary to open the left nav in order to go to another demo app:
Screenshot 2025-01-08 at 19 25 22 Screenshot 2025-01-08 at 19 25 36
  • Add code highlighter feature to watch the code associated to each demo, search by title and description and copy the code to clipboard.
Screenshot 2025-01-08 at 19 29 35 Screenshot 2025-01-10 at 16 20 06

@yduartep yduartep marked this pull request as ready for review January 9, 2025 08:36
dprokop
dprokop requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but let's get rid of unnecessary prismjs dependency.

packages/scenes-app/package.json Outdated Show resolved Hide resolved
@yduartep yduartep requested a review from dprokop January 10, 2025 15:33
@yduartep yduartep requested a review from dprokop January 14, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprokop dprokop Awaiting requested review from dprokop

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yduartep @dprokop