Better inline filter #596
Merged
Better inline filter #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Looker alpha release --------- Co-authored-by: Ian Eaves <ian.k.eaves@gmail.com>
edlouth
changed the base branch from
master
to
feature/gra-682-graphfilter-live-create-and-edit
|
Uffizzi Preview |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature/gra-682-graphfilter-live-create-and-edit #596 +/- ##
====================================================================================
- Coverage 97.18% 95.06% -2.13%
====================================================================================
Files 385 394 +9
Lines 7072 7330 +258
Branches 1043 1163 +120
====================================================================================
+ Hits 6873 6968 +95
- Misses 196 359 +163
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
edlouth
merged commit e7050c9
into
feature/gra-682-graphfilter-live-create-and-edit
38 of 41 checks passed
edlouth
added a commit
that referenced
this pull request
Aug 23, 2023
* Start on live edit * Better inline filter (#596) * Looker integration (#537) * Looker alpha release --------- Co-authored-by: Ian Eaves <ian.k.eaves@gmail.com> * Better inline filter * Partially working inline filters * Pretty much working frontend * Fix links (#593) * Fix cron hours (#594) * Fix looker icon (#595) * Add inline filters to graph type * Inline filters * Lint fixes * Backend tests --------- Co-authored-by: Ian Eaves <ian.k.eaves@gmail.com> * Frontend refactor * More tests * Fix code style issues with ESLint * Some more bits and pieces * Lint fixes * Remove acts * More tests * More frontend tests * Fix code style issues with ESLint * Refactor and tests * Fix for tags * Additional test * Test fixes * Add test --------- Co-authored-by: Ian Eaves <ian.k.eaves@gmail.com> Co-authored-by: Lint Action <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.