Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source delete confirmation show related models #762

Merged

Conversation

edlouth
Copy link
Contributor

@edlouth edlouth commented Oct 31, 2023

No description provided.

Copy link

linear bot commented Oct 31, 2023

GRA-980 Source Delete Confirmation show related models

Confirm that the user is content to delete related models in the confirmation dialog

Change source and connection to cascade delete runs etc.

Copy link
Contributor

github-actions bot commented Oct 31, 2023

Uffizzi Preview deployment-39876 was deleted.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77375e4) 95.60% compared to head (4516796) 95.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   95.60%   95.59%   -0.01%     
==========================================
  Files         467      467              
  Lines        8501     8516      +15     
  Branches     1189     1197       +8     
==========================================
+ Hits         8127     8141      +14     
- Misses        371      372       +1     
  Partials        3        3              
Flag Coverage Δ
grai-frontend 97.77% <100.00%> (-0.03%) ⬇️
grai-server 93.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nd/src/components/connections/ConnectionDelete.tsx 100.00% <100.00%> (ø)
...end/src/components/connections/ConnectionsMenu.tsx 100.00% <ø> (ø)
...nd/src/components/connections/ConnectionsTable.tsx 100.00% <ø> (ø)
.../src/components/sources/SourceConnectionsTable.tsx 100.00% <ø> (ø)
...i-frontend/src/components/sources/SourceDelete.tsx 100.00% <100.00%> (ø)
...ai-frontend/src/components/sources/SourcesMenu.tsx 100.00% <ø> (ø)
...i-frontend/src/components/sources/SourcesTable.tsx 93.33% <ø> (-6.67%) ⬇️
...rontend/src/components/tables/DataSourcesStack.tsx 100.00% <ø> (ø)
grai-frontend/src/pages/connections/Connection.tsx 100.00% <ø> (ø)
...rai-frontend/src/pages/connections/Connections.tsx 100.00% <ø> (ø)
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edlouth edlouth merged commit 90bcf62 into master Oct 31, 2023
40 of 41 checks passed
@edlouth edlouth deleted the feature/gra-980-source-delete-confirmation-show-related-models branch October 31, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant