Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create exceptions and handle in tasks #797

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

edlouth
Copy link
Contributor

@edlouth edlouth commented Nov 10, 2023

No description provided.

Copy link

linear bot commented Nov 10, 2023

GRA-983 Formalise integration exceptions

Add specific exception in grai-schemas for the following errors which the integrations can raise. These will be called from is_ready

  • NoConnection > White list docs
  • IncorrectPassword > Set validation failure on password field
  • MissingPermission

Integrations can still throw other exceptions, which the frontend will continue to handle in a generic manor

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 10, 2023 0:15am

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Uffizzi Preview deployment-40501 was deleted.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2146424) 95.54% compared to head (2fc822c) 95.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   95.54%   95.51%   -0.04%     
==========================================
  Files         466      466              
  Lines        8426     8435       +9     
  Branches     1096     1096              
==========================================
+ Hits         8051     8057       +6     
- Misses        372      375       +3     
  Partials        3        3              
Flag Coverage Δ
grai-server 93.90% <82.35%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
grai-server/app/connections/tasks.py 96.89% <82.35%> (-2.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edlouth edlouth merged commit 5ab53f8 into master Nov 10, 2023
40 of 43 checks passed
@edlouth edlouth deleted the feature/gra-983-formalise-integration-exceptions branch November 10, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant