-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groovy 4 #326
Groovy 4 #326
Conversation
@codeconsole The only holdup on Groovy 4 for the grails-gradle-plugin is: https://docs.gradle.org/current/userguide/compatibility.html#groovy "Gradle plugins written in Groovy must use Groovy 3.x for compatibility with Gradle and Groovy DSL build scripts." |
Groovy 4 appears to work and eliminates the Groovy 3 vs 4 conflicts nicely, I just wish there was confirmation that the statement from Gradle is no longer valid. |
@codeconsole Have you tried to use the plugins from this project compiled with Groovy 4? |
build.gradle
Outdated
} | ||
} | ||
} | ||
configurations.all*.exclude group: 'org.apache.groovy', module: 'groovy-xml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find It's better to use configurations.configureEach
as configurations.all
will configure all configurations eagerly (even unused configurations), while the former does so only lazily upon usage. I also like to write a comment as to why, I for example exclude something, because then it's really easy for the next developer reading the file to understand.
@puneetbehl submitted a PR with the Groovy 4 update, about 2 years ago, so this appears to have been planned for Grails 6, but Groovy 4 got bumped to Grails 7. |
|
I tested it against and it allows removal of the following from buildScript:
There are still some 7.0.0-SNAPSHOT dependencies that are referencing org.codehaus.groovy which separately need updated. org.grails:grails-gsp:7.0.0-SNAPSHOT PR for these grails/grails-gsp#477 |
The following should resolve
|
Remove large configurations block and set to groovy 4